Use paranoia_destroyed? instead of deleted? #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have you tested this in production ? |
|
test failures looks unrelated... I wonder if you are up to date? |
|
just rebase or merge |
deleted\? might be overridden by other gems, better to use the namespaced method
mlarraz
force-pushed
the
paranoia_destroyed
branch
from
19ebd22
to
b2abb61
Compare
Yes we have patched this in production and been running it for a few weeks. |
mathieujobin
approved these changes
Sep 1, 2023
karunkumar1ly
pushed a commit
to edcast/paranoia
that referenced
this pull request
Feb 6, 2024
deleted\? might be overridden by other gems, better to use the namespaced method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted?might be overridden by other gems (or the model itself), better to use the namespaced method internally.