Add recovery window option a la acts_as_paranoia #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restoring polymorphic has_one relationships errored because paranoia was
not correctly looking up the foreign_key.
Output from failing test -
ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: parent_model_id: SELECT "polymorphic_models".* FROM "polymorphic_models" WHERE ("polymorphic_models"."deleted_at" IS NOT NULL) AND (parent_model_id) ORDER BY "polymorphic_models"."id" ASC LIMIT 1
The test sets up a PolymorphicModel, which has_many parents. The
ParentModel then has a has_one relationship with PolymorphicModel. When
restoring, the foreign key is set as - `self.class.name.to_s.underscore_id`
which will be parent_model_id, instead of the :as option.
If association is a has_one relationship with an :as option, it will have a type attribute (see https://github.com/rails/docrails/blob/master/activerecord/lib/active_record/reflection.rb). If it is present, that will be the type column on the polymorphic model. The foreign key can be found as an attribute on association.
Fix polymorphic has_one relationships
|
It would be great if we could get this merged, now that #189 has been merged. |
|
👍 |
|
This would be very helpful to us. |
Closed
|
👍 |
|
In my opinion, this should be used not just for restoration but for queries--if you get the children of a deleted record, then by default, it should show you the records which have the same deletion time as the parent. I agree with @radar that it would considerably expand the scope of this project, but I think it's really what people need. |
This was referenced Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
:dependent_recovery_windowoption to makeparanoiacompatible with that feature of acts_as_paranoid.When recovering records recursively, associated records will only be restored if they were deleted within the recovery window timespan of the parent's deletion time. This is to enable recovery of a record's associations as they existed at the time it was destroyed.
The default recovery window is set to 2 minutes for compatibility with
acts_as_list.