Few fixes and features #596
Conversation
|
Hi @louiecaulfield, thanks for the PR! Looks like I will need to set aside some time soon to go through and look this over. Would you mind rebasing it on master for me? Thanks. |
| <td class="topics-count"><%= topics_count(forum) %></td> | ||
| <td class="posts-count"><%= posts_count(forum) %></td> | ||
| <td class="views-count"><%= forum.views_count %></td> | ||
| <td class="topics-count show-for-medium-up"><%= topics_count(forum) %></td> |
There was a problem hiding this comment.
What does this attribute do?
There was a problem hiding this comment.
It's a foundation-zurb thing. I didn't intend this to end up in the pull request. I'll rebase on your master and move site-specific change into a separate branch.
There was a problem hiding this comment.
But since you're asking, what it does is it hides the topics count columns on small screens so the forum overview is somewhat functional. Try https://www.lab-nation.com/forum and resize your browser window really narrow.
louiecaulfield
force-pushed
the
rails4
branch
from
38e0387
to
77839b1
Compare
louiecaulfield
force-pushed
the
rails4
branch
from
77839b1
to
848958c
Compare
|
I rebase/merged my rails4 branch on yours and isolated my CSS requirements in a different branch. Should merge fine now. |
This pull request fixes a few things. I suppose styles could be broken since I changed the views a bit to reduce code redundancy.
I believe I fixed issues #561, #443, #592 (already marked closed though) and #569
Besides that, a few unreported issues were fixed by commits
It's my first contribution to a rails engine, so I'm pretty sure I'm not doing it the right way. Please let me know what needs to change to allow my code to be pulled in.