Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 7 Upgrade #640

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Rails 7 Upgrade #640

wants to merge 18 commits into from

Conversation

bglusman
Copy link
Collaborator

@bglusman bglusman commented Jul 29, 2023 •
edited

Two tests were failing, one is fixed but in a way that may break some functionality, one is marked pending based on the error looking like it is meeting the expectation but ALSO failing in additional unexpected ways that... may be fine?

bglusman
bglusman commented Jul 30, 2023
View reviewed changes
backend/Gemfile Outdated Show resolved Hide resolved
bglusman
bglusman commented Jul 30, 2023
View reviewed changes
backend/Gemfile Outdated Show resolved Hide resolved
@bglusman bglusman changed the title rails 7 via bootboot rails 7 update candidate Jul 30, 2023
@haydenrou haydenrou mentioned this pull request Mar 13, 2024
Open
@haydenrou haydenrou changed the title rails 7 update candidate Rails 7 Upgrade Apr 18, 2024
@haydenrou haydenrou marked this pull request as draft April 18, 2024 21:35
@haydenrou
Copy link
Collaborator

Noting that running bin/rails app:update has made a bunch of changes to config files that we may need to revert. For instance, 47c946a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
language:ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bglusman @haydenrou @johnpaulashenfelter