Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully qualify paths where necessary #97

Merged
merged 1 commit into from May 24, 2024

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Dec 21, 2021

No description provided.

# Classes
module Qux
module Foo
class Bar < ::Foo::Bar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, this would be missing the leading ::

mame added a commit to mame/typeprof that referenced this pull request May 24, 2024
Co-Authored-by: Peter Wagenet <peter.wagenet@gmail.com>
@mame mame merged commit 6fc1f22 into ruby:master May 24, 2024
@mame
Copy link
Member

mame commented May 24, 2024

Sorry for very late response! I've merged it.

I'm reworking the algorithm on the v2 branch now. But your test in this issue doesn't work on v2 branch, so I copied your test as a known-issue. #192

mame added a commit that referenced this pull request May 24, 2024
Co-Authored-by: Peter Wagenet <peter.wagenet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants