Fix conflict between Hash#values_at and "Parallel Assignment"
#936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydakuka
changed the title
Hash#values_at and "Parallel Assignment"Hash#values_at and "Parallel Assignment"
ydakuka
commented
Nov 23, 2023
README.adoc
Outdated
| @@ -2297,7 +2297,7 @@ Prefer the use of exceptions from the standard library over introducing new exce | |||
| === Parallel Assignment [[parallel-assignment]] | |||
|
|
|||
| Avoid the use of parallel assignment for defining variables. | |||
| Parallel assignment is allowed when it is the return of a method call, used with the splat operator, or when used to swap variable assignment. | |||
| Parallel assignment is allowed when it is the return of a method call, used with the splat operator, or when used to swap variable assignment, or `Hash#values_at` and `Hash#fetch_values`. | |||
There was a problem hiding this comment.
These built-in methods are very convenient. However, there are many such methods, so it is difficult to come to a common solution without marking them as "bad".
There was a problem hiding this comment.
Those are method calls, so it's already covered in this sentence.
There was a problem hiding this comment.
Maybe the language could to be tweaked to something like "return of a method call (e.g. Hash#values_at)..." so this is clearer.
bbatsov
reviewed
Nov 23, 2023
README.adoc
Outdated
| @@ -4404,18 +4404,25 @@ batman.fetch(:powers, obtain_batman_powers) # obtain_batman_powers is an expensi | |||
| batman.fetch(:powers) { obtain_batman_powers } | |||
| ---- | |||
|
|
|||
| === `Hash#values_at` [[hash-values-at]] | |||
| === `Hash#values_at` [[hash-values-at-and-fetch-values]] | |||
There was a problem hiding this comment.
You should check if something in RuboCop doesn't refer to this anchor before changing it.
There was a problem hiding this comment.
Sure, there are no links to this anchor.
ydakuka
force-pushed
the
fix-hash-values-at
branch
from
f532471
to
590d468
Compare
ydakuka
force-pushed
the
fix-hash-values-at
branch
from
590d468
to
8000356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.