Respect user's intentions with workspace/executeCommand LSP method
#12897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: Shopify/ruby-lsp#1453 (comment) The `workspace/executeCommand` is an LSP method triggered by intentional user actions, so the user's intention for autocorrection is respected. It has not yet been implemented in RuboCop's built-in LSP, but the same could be said for `textDocument/codeAction` LSP method, which might be implemented in the future. This change slightly alters the behavior of `AutoCorrect: contextual` when using LSP (or the `--editor-mode` option), and this has been documented accordingly.
|
@bbatsov Oops, I accidentally merged this PR. I think it may be logically sound, but if you notice any issues that might arise from the merge, please don't hesitate to let me know. I'm open to making corrections or reverting if necessary 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Shopify/ruby-lsp#1453 (comment)
The
workspace/executeCommandis an LSP method triggered by intentional user actions, so the user's intention for autocorrection is respected.It has not yet been implemented in RuboCop's built-in LSP, but the same could be said for
textDocument/codeActionLSP method, which might be implemented in the future.This change slightly alters the behavior of
AutoCorrect: contextualwhen using LSP (or the--editor-modeoption), and this has been documented accordingly.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.