Upgrade to OkHttp 4 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
force-pushed
the
remove-use-of-okhttp-internal-class-HttpDate
branch
2 times, most recently
from
9580732
to
5b75bf4
Compare
This upgrade was prompted by guardian/prout#114, where Ash noted that updating to OkHttp 4 was blocked by `play-git-hub`s use of OkHttp 's internal `HttpDate` class. Thankfully the `java.time` package offers the `RFC_1123_DATE_TIME` date time formatter, which looks to be a good substitute for parsing the `Date` header returned by the GitHub API. https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html#RFC_1123_DATE_TIME
rtyley
force-pushed
the
remove-use-of-okhttp-internal-class-HttpDate
branch
from
5b75bf4
to
c4a25ee
Compare
AshCorr
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade was prompted by guardian/prout#114, where @AshCorr noted that updating to OkHttp 4 was blocked by
play-git-hubs use of OkHttp's internalHttpDateclass.Thankfully the
java.timepackage offers theRFC_1123_DATE_TIMEdate time formatter, which looks to be a good substitute for parsing theDateheader returned by the GitHub API, so we can moveplay-git-hubon to the latest OkHttp!