Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imfile - proposed fix for file handle leaks #5335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n2yen
Copy link
Contributor

@n2yen n2yen commented Feb 23, 2024

  • FIle handler leaks can occur if the deleted file still has a lingering symbolic link (pointing to it). Reason is, even if the file has actually been deleted, fstat will return successfully, and thus this block never gets a chance to release the file handle.

- FIle handler leaks can occur if the deleted file still has a lingering symbolic link, even if the file has actually been deleted.
@n2yen n2yen changed the title proposed fix for file handle leaks proposed fix for file handle leaks in imfile Feb 23, 2024
@n2yen n2yen changed the title proposed fix for file handle leaks in imfile imfile - proposed fix for file handle leaks Feb 23, 2024
@n2yen
Copy link
Contributor Author

n2yen commented Feb 23, 2024

hi @rgerhards ,
Wonder if this is one of the possible edge cases discussed:

TODO: check the full implications, there are for sure some!
e.g. file has been closed, so we will never have old inode (but
why was it closed then? --> check)

mind having a look when you get a chance? thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant