Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: remove bashisms #5024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xgqt
Copy link

@xgqt xgqt commented Nov 16, 2022

replace [[ ]] (actually [ ] ) with test and == with =

Signed-off-by: Maciej Barć xgqt@gentoo.org

@xgqt
Copy link
Author

xgqt commented Nov 16, 2022

See also: https://bugs.gentoo.org/881381

@xgqt
Copy link
Author

xgqt commented Nov 16, 2022

Ad replacing [[ ]] with [ ]:

a.log

Those changes seem to break running autogen.sh.

This is because [[ ]] is special in m4.

replace [[ ]] with test and == with =

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@xgqt
Copy link
Author

xgqt commented Nov 16, 2022

in reality the bug was not with [[ ]] (which "expands" to [ ]) but with using == used instead of =

@xgqt
Copy link
Author

xgqt commented Nov 26, 2022

@rgerhards Could you comment on this? Was I completely wrong here or can changing == to = in configure be taken into consideration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant