Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Replace deprecated substr method with substring #3681

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

govindarajit
Copy link
Contributor

This commit updates the codebase to replace the deprecated substr method with substring. By doing so, we ensure compatibility with modern JavaScript standards and maintain codebase integrity across environments.

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 0:49am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 0:49am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 0:49am

Copy link

vercel bot commented Mar 17, 2024

Someone is attempting to deploy a commit to the rsuite Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@simonguo simonguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modified code has not been tested. You can test your code by running the following command:

F=src/MaskedInput/test/adjustCaretPositionSpec.ts npm run tdd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants