Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tooling): upgrade stylelint 15 #3304

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Jul 25, 2023

UPDATE

Unified stylelint-less has been released stylelint-less/stylelint-less#10 (comment). This PR can be continued.

PENDING

Pending on issue stylelint/stylelint#7096

According to Stylelint members, the recommended practice of using Stylelint with Less is to use Less-specific standard config like stylelint-config-standard-less. I tried using it but it seemed broken, throwing syntax error errors. It looks like its dependencies stylelint-config-recommended-less and stylelint-less are not ready to work with Stylelint 15 yet.

Pasted Graphic 4

However, the package and its dependencies are right in the process of transforming from separate repos maintained by different owners to a monorepo held by a community org (see stylelint-less/stylelint-config-standard-less#1 and ssivanatarajan/stylelint-less#15), so things are getting better just around these days. I'm keeping an eye on it.

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 9:40am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Jul 25, 2023 9:40am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a58213:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (58cfbf4) 93.37% compared to head (4a58213) 93.37%.
Report is 38 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3304   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files         568      568           
  Lines       20221    20221           
  Branches     2770     2770           
=======================================
  Hits        18881    18881           
  Misses        688      688           
  Partials      652      652           
Flag Coverage Δ
ChromeCi 93.21% <ø> (-0.12%) ⬇️
Firefox 92.60% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant