Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectPicker): data prop accepts readonly array #2961

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Dec 5, 2022

@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ❌ Failed (Inspect) Dec 5, 2022 at 7:40AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Dec 5, 2022 at 7:40AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 5, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 161e530:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 93.05% // Head: 93.05% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (161e530) compared to base (cab5c63).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2961      +/-   ##
==========================================
- Coverage   93.05%   93.05%   -0.01%     
==========================================
  Files         557      557              
  Lines       19984    19984              
  Branches     2716     2716              
==========================================
- Hits        18597    18596       -1     
  Misses        734      734              
- Partials      653      654       +1     
Flag Coverage Δ
ChromeCi 93.01% <100.00%> (-0.01%) ⬇️
Firefox 92.29% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Picker/utils.ts 84.68% <ø> (ø)
src/SelectPicker/SelectPicker.tsx 90.19% <100.00%> (ø)
src/Menu/Menu.tsx 91.33% <0.00%> (-0.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant