Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Picker,Dropdown): change caret icon #2537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Jun 13, 2022

Before
image

After
image

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 11:39AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Jun 13, 2022 at 11:39AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b8b3c8:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #2537 (7b8b3c8) into main (746c2b2) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
+ Coverage   85.28%   85.30%   +0.02%     
==========================================
  Files         293      293              
  Lines        9084     9084              
  Branches     2552     2552              
==========================================
+ Hits         7747     7749       +2     
+ Misses        701      700       -1     
+ Partials      636      635       -1     
Flag Coverage Δ
ChromeCi 85.28% <50.00%> (ø)
Firefox 85.28% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/useToggleCaret.tsx 57.14% <50.00%> (ø)
src/utils/useRootClose.ts 84.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 746c2b2...7b8b3c8. Read the comment docs.

Copy link
Member

@simonguo simonguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得修改前的图标从视觉上来说更合理一些

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants