Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align shinydashboard tab data-value with shiny tabs #390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carlganz
Copy link

I guess you'd probably want to update the codebase to use bslib, but since that is a lot of work updating shiny dashboard tabs to include a data-value will allow other shiny related packages (like mine) to work with tabs across shiny and shiny dashboard in a generic way (see https://github.com/carlganz/rintrojs/blob/master/inst/javascript/rintro.js#L48)

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@YongbingDing
Copy link

YongbingDing commented Sep 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants