Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 1380 Sticky Header Update #1385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ax-jkriese
Copy link

Adds functionality for a sticky header for mobile

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jtbayly
Copy link
Contributor

jtbayly commented May 5, 2023

Is this too risky to merge, or something, @cderv?

I'm trying to decide whether I should wait for it or figure out how to pull in this code when building our books.

@cderv cderv linked an issue May 5, 2023 that may be closed by this pull request
@cderv
Copy link
Collaborator

cderv commented May 5, 2023

I want to find time to test it and see the impact it has, especially on current users. As you have tested it, is this something that some users would want to opt-out ?

My understanding was that it was for mobile only, but the current change seems to also modify the CSS for current style of non mobile view. I don't want to force changes of style to all existing bs4_book.

Maybe we need some media query rule to use the CSS based on size of screen ? https://ui.dev/rwd/develop/browser-feature-support/media-queries-for-common-device-breakpoints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] make the bs4_book sticky menu sticky on mobile
4 participants