Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] make the bs4_book sticky menu sticky on mobile #1380

Open
jtbayly opened this issue Sep 1, 2022 · 4 comments · May be fixed by #1385
Open

[FR] make the bs4_book sticky menu sticky on mobile #1380

jtbayly opened this issue Sep 1, 2022 · 4 comments · May be fixed by #1385
Assignees
Labels

Comments

@jtbayly
Copy link
Contributor

jtbayly commented Sep 1, 2022

From the bookdown guide about bs4_book: "Thoughtful typography to make the contents as easy as possible to read, regardless of the size of your device. A sticky header gets out of your way when reading, but is easily accessible if you need it.”

The bs4_book menu is not sticky on small screens. (This might be a bug report, given what the documentation says?)

If I'm reading in the middle of a long page, and I want to go to another part of the book, I have no obvious way on the screen to do so. I have to remember that there was a hamburger menu at the top of the page, and I have to know what it does already. It would be really handy to have a sticky menu on mobile, especially when you are reading a long page.

In particular, "sticky" implies to me that the hamburger menu for the TOC floats on the screen, or if it disappears, it shows back up the moment I start scrolling back up toward the top of the page.

@cderv
Copy link
Collaborator

cderv commented Sep 2, 2022

In particular, "sticky" implies to me that the hamburger menu for the TOC floats on the screen, or if it disappears, it shows back up the moment I start scrolling back up toward the top of the page.

I would love to have that ! I am not an expert in mobile friendly development, so I don't know an easy way to do this. Maybe Bootstrap has component to help us with that.

So it would require a bit of learning about CSS and web development for mobile friendly website.

If anyone wants to help, please do !

@cderv cderv added feature a feature request or enhancement theme: mobile friendly bs4_book 🥾 labels Sep 2, 2022
@ax-jkriese
Copy link

Hey there @cderv, @jtbayly asked if I could lend a hand to help out with making the menu sticky, here's a PR on a fork that includes that update: #1385

Let me know what you think!

@cderv
Copy link
Collaborator

cderv commented Sep 19, 2022

Awesome @ax-jkriese ! Thank you. I'll look at that shortly. Really appreciating the help

@jtbayly
Copy link
Contributor Author

jtbayly commented Sep 20, 2022

Wow, this looks great, @ax-jkriese. Just what I was hoping for. Thanks again.

@cderv cderv linked a pull request May 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants