Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Added New remote component: local storage #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lastmeta
Copy link
Contributor

added local storage option for linux and windows for use, most often, in backing data to a mounted shared drive. Also added purge command that deletes the lazydata.yml and the .aws and .lazydata.

@rstojnic
Copy link
Owner

Thanks very much for this PR - this is amazing work!

I would like to suggest three things:

  1. Would you mind renaming the purge command into something a bit more drastic, like remove-all-tracking or something like that. I would like to reserve the purge command for something less drastic eg. purge only the local cache in ~/.lazydata for those files that are already stored remotely.
  2. Can you resolve the conflict with the current master?
  3. Would it be possible to add some tests for this new local storage? I hope this shouldn't be too much work - probably just adding a couple of lines to tests/test_local_project.py.

@lastmeta
Copy link
Contributor Author

Thanks very much for this PR - this is amazing work!

I would like to suggest three things:

  1. Would you mind renaming the purge command into something a bit more drastic, like remove-all-tracking or something like that. I would like to reserve the purge command for something less drastic eg. purge only the local cache in ~/.lazydata for those files that are already stored remotely.
  2. Can you resolve the conflict with the current master?
  3. Would it be possible to add some tests for this new local storage? I hope this shouldn't be too much work - probably just adding a couple of lines to tests/test_local_project.py.

Yes, I'll try to get to that, but it might not be soon. turns out the use case I created all this code for isn't actually going to materialize, so I'm working on other stuff now. But yes, I think your suggestions are a good idea.

@Avsecz
Copy link

Avsecz commented Oct 14, 2018

the new track command is exactly what I specified in #15. So the issue can be closed. Is it possible to make it work with multiple files? This would allow to use bash expansion: lazydata track *.ext

@rstojnic
Copy link
Owner

Continuing work in the PR12 branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants