Make the hl_lines directive work with plain text #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more usefult to display its name, rather than its index position in the list!
As plain text code blocks have a different path through the codeblock directive, we need to apply the hl_lines diml class in this section in order for highlighting to work. Also, improve the Python test to show that syntax highlighting works on the highlighted lines.
lornajane
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As plain text code blocks have a different path through the codeblock directive, we need to apply the hl_lines "
diml" class in this section too in order for highlighting to work.I've also improved the Python test to show that syntax highlighting works on the highlighted lines and updated an error message to show the name of a class rather than its index within the list of classes.
This is an example from the new test in this PR:
RST code:
Before this PR, only the first line number is dimmed:
After, it works as you'd reasonably expect:
