Fix test failures #1134
Merged
Fix test failures #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `--record-dependencies` option is not set, then do not record dependencies. There's no need to do this work if we don't want to output the results. In addition, it breaks Sphinx and there's no way to turn it on when using Sphinx anyway.
Now that we have restored TwoColumn back into the default stylesheet, this test generates a two column PDF.
This was referenced Mar 16, 2023
Merged
lornajane
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way our CI was set up and a failure to manually run the pytest tests locally before merging, we ended up merging two PRS (#1111 and #1126) that broke the tests. This PR fixes both.
For #1126,
test_stylesheet_includesis now a two-column PDF again so we need to update the reference file.For #1111, recording dependencies breaks Sphinx, which does't even allow this option to be set. Hence, if the
--record-dependenciesoption is not set, we no longer do the recording as we're not going to use the result anyway.