Add deprecation warnings for features to be removed/changed in RSpec 4 #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
add-major-update-deprecation-warnings
branch
from
a74c7a7
to
445aa10
Compare
pirj
force-pushed
the
add-major-update-deprecation-warnings
branch
2 times, most recently
from
c192369
to
02fb699
Compare
pirj
commented
Mar 15, 2021
| @@ -80,13 +80,23 @@ def add_stub_and_should_receive_to(*modules) | |||
| # | |||
| def syntax=(*values) | |||
| syntaxes = values.flatten | |||
| if self.class.warn_about_syntax? | |||
There was a problem hiding this comment.
We call configuration.reset_syntaxes_to_default, and don't want a deprecation message to be emitted at that moment.
pirj
force-pushed
the
add-major-update-deprecation-warnings
branch
from
02fb699
to
f7da8b4
Compare
pirj
force-pushed
the
add-major-update-deprecation-warnings
branch
from
f7da8b4
to
0968af2
Compare
|
To prevent the build from failing, I had to comment out this in # c.raise_errors_for_deprecations!Made it part of rspec/rspec-core#2880. |
2 tasks
|
This will become green when rspec/rspec-core#2880 is merged. Still, preliminary code review is appreciated. |
JonRowe
approved these changes
Apr 23, 2021
pirj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/rspec/rspec-mocks/blob/4-0-dev/Changelog.md, only those two deprecation warnings are needed.
This is purposed to be released as version 3.99. Similar PRs for Expectations will follow.
Sibling PRs:
Release strategy: rspec/rspec-core#2880 (comment)
See https://github.com/rspec/rspec/issues/61
RSpec 4 plan: https://github.com/rspec/rspec/issues/61
Changes https://github.com/rspec/rspec-mocks/blob/4-0-dev/Changelog.md#development