-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NIST P curve support to ECDH #351
Conversation
82d920a
to
57f75c1
Compare
would be nice to add benchmarks and tests for these new formats, following the existing ones |
043b57e
to
7374480
Compare
- SecretKey is now an enum - add curve parameter to KeyType::ECDH and ecdh::generate_key - generalize ecdh shared_secret handling to flexible length
I extended the benchmarks, which seemed straightforward. Regarding tests i am unsure what to extend. I did already add nist curve tests to Lines 543 to 548 in 3b91018
It looks like the corpus in |
overall looking great, will take some time in the next day to go over the actual crypto algorithms once more |
@hko-s want to move it out of draft, or is there sth else you want to do? |
i thought it'd be nice to shape it into two commits: one that just transforms the previous code, and one that implements nistp. |
thanks :) |
No description provided.