Hapi 18 support #63
Open
Hapi 18 support #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
hapi-18-support
branch
from
cdcad38
to
bcfa271
Compare
|
Anything that is blocking this from being merged @roylines ? |
achingbrain
added a commit
to libp2p/js-libp2p-websocket-star-rendezvous
that referenced
this pull request
Jul 19, 2019
|
FWIW I have published a fork of this module with this PR merged as menoetius. Hopefully this PR will get merged one day and then I can delete it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the work done by @Y-LyN-10 in #52 to run the tests with Hapi 18 to ensure support.