Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use route path instead of url in metric labels #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YvesPasteur
Copy link

The previous method to deal with the Url doesn't handle very good routes like /foo/123/bar where foo and bar are resource names and 123 is a changing id.

We change to use the routes as defined in the routers with placeholders, ex : '/foo/{id}/bar'

@galbacarys
Copy link

Can this please be merged in? This would fix the issue I'm having as well.

@roylines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants