feat: Certificates Update #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o classroomio-issue-272
…o classroomio-issue-272
…t/classroomio into classroomio-issue-272
- translation bug fix
…t/classroomio into classroomio-issue-272
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
tunny17
force-pushed
the
classroomio-issue-272
branch
from
9d086d7
to
0af5ff9
Compare
…o classroomio-issue-272
…o classroomio-issue-272
…t/classroomio into classroomio-issue-272
rotimi-best
requested changes
May 30, 2024
Comment on lines
+48
to
+53
| try { | ||
| courseSchema.parse({ | ||
| description: $course.description || '', | ||
| is_certificate_downloadable: $course.is_certificate_downloadable || false, | ||
| certificate_theme: $course.certificate_theme || '' | ||
| }); |
There was a problem hiding this comment.
@tunny17 Use the validation approach we use and not expose a schema to a component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #289
Type of change
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated