This repository has been archived by the owner on Jan 14, 2023. It is now read-only.
Fixes serialization of non-initialized ChannelBufferField #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uninitialized fixed-length uint8 array messages (which are compiled into ChannelBufferField objects) were being serielized as a 0-length array, causing very obscure problems.
This was detected when trying to use uuid_msgs/UniqueID as part of another message. The resulting symptom was that no message was being published.
@ernestmc could you please review this fix and test with the failing project when you get a chance?