Use CMAKE_STAGING_PREFIX for staging OGRE installation (backport #861) #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
To maintain build/install phasing correctly, this vendor package is installing the external project to a staging location, which is then recursively copied to the final location during the vendor package's installation phase. The mechanism by which we're currently telling the external project where to install to gives it the impression that that will be the final destination, and it embeds such paths in places like pkgconfig files. The CMAKE_STAGING_PREFIX can be used to override all of the `install()` operations' targets while still telling the project where it will eventually end up, which is pretty much exactly what we're trying to do. Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 47e91ee)
|
I'd like to wait until we've seen this patch in action in Rolling before we merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #861 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com