Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix same named types overriding typesources (backport #759) #760

Open
wants to merge 1 commit into
base: iron
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 26, 2023

This is an automatic backport of pull request #759 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix same named types overriding typesources

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 89c6713)
@emersonknapp
Copy link
Collaborator

Pulls: #760
Gist: https://gist.githubusercontent.com/emersonknapp/406bc27d5e7b65b2588acc4981e58102/raw/55b0845f79f3cdde977aa93e85209780f9c20dd3/ros2.repos
BUILD args:
TEST args:
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12439

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp self-assigned this Jul 26, 2023
@emersonknapp
Copy link
Collaborator

emersonknapp commented Jul 27, 2023

Windows failed tests were unrelated, rerunning:

  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Oct 13, 2023

@Mergifyio rebase

@mergify
Copy link
Author

mergify bot commented Oct 13, 2023

rebase

✅ Nothing to do for rebase action

@sloretz
Copy link
Contributor

sloretz commented Oct 13, 2023

@emersonknapp Looks like CI passed. Is this good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants