Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to support complete for rosidl and avoid calling multiple compinit #702

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

to support complete for rosidl and avoid calling multiple compinit #702

wants to merge 2 commits into from

Conversation

iuhilnehc-ynos
Copy link
Contributor

Signed-off-by: Chen Lihui lihui.chen@sony.com

@iuhilnehc-ynos
Copy link
Contributor Author

to fix ros2/ros2_documentation#2944

to support complete for rosidl and avoid calling multiple compinit
d8cacb3 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
to separate checking to call compinit and bashcompinit
ffddfe5 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@mjbogusz
Copy link

Cross-ref ros2/ros2cli#534

@fujitatomoya fujitatomoya mentioned this pull request Jan 15, 2023
Open
@mjbogusz
Copy link

If I understand correctly, this solution relies on checking whether functions compdef and complete exists and assumes that if so, then they must have been called.
This MIGHT conflict with other systems/scripts that either utilize completion or define functions with such names. For example I have NVM installed (note: the nvm script merely calls bashcompinit):

$ type compdef
compdef is a shell function from /usr/share/zsh/functions/Completion/compinit
$ type complete
complete is a shell function from /home/mjbogusz/.nvm/bash_completion

Note however that this might not be a problem at all, I'm just documenting my observations.

mjbogusz added a commit to mjbogusz/rosidl that referenced this pull request Jan 17, 2023
@mjbogusz
rosidl_cli: add colcon hooks
fe33378 
Based on Chen Lihui's (@iuhilnehc-ynos) PR: ros2#702
@mjbogusz mjbogusz mentioned this pull request Jan 17, 2023
Open
mjbogusz added a commit to mjbogusz/rosidl that referenced this pull request Jan 17, 2023
@mjbogusz
rosidl_cli: add colcon hooks
c2252c5 
Based on Chen Lihui's (@iuhilnehc-ynos) PR: ros2#702

Signed-off-by: Maciej Bogusz <mjbogusz+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iuhilnehc-ynos @mjbogusz