Update the current state of char in rclpy
#4420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`char` currently translates to `int` not `str` in `rclpy` Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
There was a problem hiding this comment.
although this fixes the doc aligned with current implementation, we need to fix this bug ros2/rosidl#775, right? Or are you suggesting we should not fix this bug (i think in this case this is not a bug any more...) because this can affect the downstream packages?
IMO, we need to fix this eventually... @sloretz @clalancette what do you think?
|
Yeah I'm suggesting lets not fix this. I dont think the tradeoff is worth it. Imagine the end users having to upgrade their code base for this. Its not really a show stopper anywhere. Either ways whatever decision we come to we should make sure the docs reflect reality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charcurrently translates tointnotstrinrclpy.See: ros2/rosidl#775
After attempting to change this in my spare time I think any change will caused more confusion and suffering for end users.