Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to example_interfaces #4336

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

CursedRock17
Copy link
Contributor

This pull request is meant to address #3358, pairing with this pull request over in examples: ros2/examples#377. Most std_msgs were deprecated about 4 years ago, so I think it's fair to update the tutorials to go along with that. This pull request doesn't technically finish #3358 since I still need to update some tutorials in demos which continues to use std_msgs and the user needs to have an accurate repository to tutorial pipeline.

Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@CursedRock17
Copy link
Contributor Author

All the references to std_msgs have been removed except for old versions of ROS in which it would have still been valid, or with Header, but this should sit still until changes in demos and examples are both merged.

@sloretz
Copy link
Contributor

sloretz commented May 9, 2024

Assigned to @ahcorde to make the switch post-Jazzy release 🧇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants