fixed missed installation of the .yaml parameters file #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the section "2.2 Loading parameters from YAML file", it was missing the necessity of installing the .yaml file. I tested what is written in C++ Signed-off-by: AlessandroMelone <63403736+AlessandroMelone@users.noreply.github.com>
ahcorde
requested changes
Apr 11, 2024
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
…ge-Projects.rst added empty line before the code-block Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: AlessandroMelone <63403736+AlessandroMelone@users.noreply.github.com>
…ge-Projects.rst added empty line before the code-block Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: AlessandroMelone <63403736+AlessandroMelone@users.noreply.github.com>
removed empty line as suggested by ahcorde Signed-off-by: AlessandroMelone <63403736+AlessandroMelone@users.noreply.github.com>
ahcorde
requested changes
Apr 12, 2024
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
…ge-Projects.rst Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: AlessandroMelone <63403736+AlessandroMelone@users.noreply.github.com>
fujitatomoya
requested changes
Apr 13, 2024
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
…ge-Projects.rst Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: AlessandroMelone <63403736+AlessandroMelone@users.noreply.github.com>
…ge-Projects.rst Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: AlessandroMelone <63403736+AlessandroMelone@users.noreply.github.com>
clalancette
requested changes
Apr 15, 2024
Comment on lines
+223
to
+241
| Make sure that you have installed the ``turtlesim.yaml`` file. If you have a C++ package, write in the package ``CMakeLists.txt``: | ||
|
|
||
| .. code-block:: cmake | ||
| install(DIRECTORY | ||
| config | ||
| DESTINATION share/${PROJECT_NAME} | ||
| ) | ||
|
|
||
| Instead, if you have a Python package, add in package ``setup.py`` file: | ||
|
|
||
| .. code-block:: Python | ||
| data_files=[ | ||
| ('share/ament_index/resource_index/packages', | ||
| ['resource/' + package_name]), | ||
| ('share/' + package_name, ['package.xml']), | ||
| (os.path.join('share', package_name, 'launch'), glob('launch/*.launch.py')), | ||
| (os.path.join('share', package_name, 'config'), glob('config/*.yaml')) | ||
| ], | ||
|
|
There was a problem hiding this comment.
This whole thing should go above the line If we now start... above.
Further, the way we handle C++ vs. Python in other tutorials is through the use of group-tabs, and I think we should do the same here. You can see an example of this in action in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the section "2.2 Loading parameters from YAML file", it was missing the necessity of installing the .yaml file. Missing that step, I was not generating the .yaml file in the /install folder, and therefore getting a runtime error.
I tested what is written in C++.
I was able to understand the solution to my problem thanks to this guide https://roboticsbackend.com/ros2-yaml-params/