Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QoS Magic Number note #4157

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Add QoS Magic Number note #4157

wants to merge 1 commit into from

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Feb 2, 2024

This number needs to be documented.

@DLu DLu mentioned this pull request Feb 2, 2024
Merged
@audrow
Copy link
Member

audrow commented Feb 15, 2024

Hey @DLu, can you double check if these values are specific to different DDS implementations?

@audrow audrow added the more-information-needed Further information is required label Feb 15, 2024
@DLu
Copy link
Contributor Author

DLu commented Feb 15, 2024

Hey @DLu, can you double check if these values are specific to different DDS implementations?

Honestly, if someone wants to do that they can, but otherwise it just seems like a roadblock to getting better documentation.

@fujitatomoya
Copy link
Collaborator

INFINITE is rmw dependent definition as below. and ROS 2 just handles that as INFINITE but exact digits.

  • rmw_fastrtps to Fast-DDS

https://github.com/ros2/rmw_fastrtps/blob/117c64855f3d49544c04feacdb67e8f39ae9a82a/rmw_fastrtps_shared_cpp/src/time_utils.cpp#L23-L33

  • Fast-DDS to rmw_fastrtps

https://github.com/ros2/rmw_fastrtps/blob/117c64855f3d49544c04feacdb67e8f39ae9a82a/rmw_fastrtps_shared_cpp/src/qos.cpp#L42-L49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@clalancette clalancette Awaiting requested review from clalancette clalancette is a code owner

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
more-information-needed Further information is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DLu @audrow @fujitatomoya