Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color to multiversion make command #3660

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

cychitivav
Copy link
Contributor

@cychitivav cychitivav commented May 22, 2023

I used ANSI escape codes to add color to multiversion command:

Previous

image

Now

image

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will say that I am reluctant to do this. The main reason is that while this works on Linux terminals, hard-coding it here means that this is going to look weird on e.g. Windows. So while Windows is definitely not a primary development target for this, I don't really feel like this is important enough to break it.

@cychitivav
Copy link
Contributor Author

I have added variables to prevent it from looking weird in the code. I understand that maybe it is not a major change, but I think it is something useful for new people who want to contribute to note that multiversion is also a make command. I say this because at first, I thought it was a continuation of the previous line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants