Added README.md for dummy_robot_bringup. #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocumented expected behaviour. Verified instructions. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
cardboardcode
changed the title
cardboardcode
changed the title
…ions for better cross-platform-compatibility. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
cardboardcode
requested review from
adityapande-1995 and
mjeronimo
as code owners
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
clalancette
requested changes
Jan 23, 2023
dummy_robot/dummy_robot_bringup/launch/dummy_robot_bringup.launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
|
Testing for dependency cycles :
|
adityapande-1995
requested changes
Mar 9, 2023
dummy_robot/dummy_robot_bringup/launch/dummy_robot_bringup.launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
There was a problem hiding this comment.
Could you please resolve the conflicts here @cardboardcode ? Looks good to me otherwise.
|
Rebased pull request branch to newly updated main rolling branch. Conflicts should now be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Pull Request
This pull request adds a
README.mdto dummy_robot_bringup as part of efforts to address the issue highlighted in #531.