-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install RHEL-8 pip packages in Dockerfile-RHEL. #774
Conversation
81328f0
to
761adee
Compare
And success there, so switching this to a real PR. |
Won't this cause the Actually, the Humble+RHEL-8 amd64 job failed because of exactly this issue. The newer version of pytest isn't getting used. |
Oh, hm. Possibly. Do you have suggestions on how to fix it? Ideas that I have include:
|
If (2) is where the problem is, I feel like (2) should have the solution too. How is this not a problem on Ubuntu? Are they patching the default behavior of pip or something? |
We're getting away with it on Ubuntu Jammy and Ubuntu Noble because we aren't installing any pip packages at present. I'm not sure why we aren't seeing a problem on RHEL-9, where we are installing some packages via |
Oof, seems sketchy, but I won't rock the boat. Let's just move the new |
Yep, got it. Done in a0fa99a, let's see if the failing CI is happy first, then I'll go run everything else: |
Here's a try with a totally different tactic; installing the pip packages inside the Dockerfile-RHEL for RHEL-8. This has some other disadvantages (namely duplication with what is in Let's see how this works, and if this is better, we can discuss details: |
OK, so what is in 314e224 right now actually works. And while going that direction is my long-term goal, I think that for the purposes of fixing Humble here, it will be easier to just add a constraint in |
314e224
to
4347853
Compare
2e9fb5b
to
bd953ea
Compare
It turns out that on RHEL-8, we need to install a handful of packages from pip. Doing this means that the pip installation within __main__.py will do exactly nothing, since all dependencies are already installed. This actually fixes two bugs: 1. There is currently a bug where trying to run 'pip install foo' on RHEL-8 hits a permission denied error. This change avoids it by running that pip install when we are effectively root in the container. 2. Installing a too new version of pycodestyle doesn't work with the pinned pytest that we are using. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
2b3f0df
to
a2e9ea8
Compare
All right. After discussion and a lot of small PRs here, I think the solution that is implemented in this PR is right way to go. In particular, we Here is CI on all flavors of RHEL: |
@cottsay friendly ping 🧇 |
This is so that on RHEL-8, where we actually do
install pip packages, we install to user locations and not the system.