Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforms to global frame before checking quaternion #1261

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

robbiefish
Copy link

This PR allows goals to be accepted if the quaternion is valid once the goal has been transformed into the global_frame instead of requiring the quaternion to be valid in the original frame it was sent in.

For my application, I have defined the transform from earth -> map. My map frame is in the ENU local tangent plane. Since there is a rotation between ECEF and ENU, that rotation is expressed in my transform tree.

The global_frame that I configure for the planner is still the map frame, and I want to be able to send waypoints in both the earth, and map frame.

When I attempt to send a goal point in the earth frame, the quaternion is not "mostly vertical" in the earth frame, but it is once it has been transformed to the global_frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant