avoid copying of data when dealing with observations #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorezyuk
force-pushed
the
dima/observation_buffer
branch
from
83477f3
to
fb19b25
Compare
dorezyuk
force-pushed
the
dima/observation_buffer
branch
from
fb19b25
to
17a889b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've noticed that we create a deep copy of the point clouds every time we are querying to get the observations. I've exchanged the raw pointer to a const shared pointer (we do not modify the observations).
Additionally I've changed the box-filter algorithm to work without an additional buffer.
The changes reduced the CPU load of a mbf-node (just running the voxel layer) on my system by ~7% (its not much, but...)
Best,
Dima