Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take .clang-format from moveit #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

JStech
Copy link
Contributor

@JStech JStech commented Apr 20, 2021

Not that different, in the end. Closes #72.

Copy link

@schornakj schornakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through the changes to .clang-format (and compared it to the original file linked in the issue), and I think this looks OK!

e: Other than the build/test CI steps, though I don't think that's limited to just this issue.

@tylerjw
Copy link
Member

tylerjw commented Apr 26, 2021

It looks like something is broken in the cache. You'll need to go into the settings for this repo and delete the cache and run this again.

@rhaschke
Copy link
Contributor

You'll need to go into the settings for this repo and delete the cache and run this again.

So far, I haven't seen any possibility to delete the cache manually. Have you?

@tylerjw
Copy link
Member

tylerjw commented Apr 26, 2021

So far, I haven't seen any possibility to delete the cache manually. Have you?

I thought there was a way to do this in the repo settings. However it looks like this is not actually a feature and I'm probably just thinking of doing this in GitLab: actions/cache#2

A workaround for that would be to add an arbitrary version to the cache prefix like -v2 or something like that.

However looking more closely at this it seems that maybe there is something wrong with the melodic-source docker image that's causing this.

@JStech
Copy link
Contributor Author

JStech commented May 1, 2021

However looking more closely at this it seems that maybe there is something wrong with the melodic-source docker image that's causing this.

It seems the UNDERLAY change isn't working as intended: #82

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #81 (edb0c9b) into master (034f951) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files          10       10           
  Lines         554      554           
=======================================
  Hits          403      403           
  Misses        151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 034f951...edb0c9b. Read the comment docs.

@JStech JStech requested review from felixvd and rhaschke May 18, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import .clang_format from MoveIt
4 participants