Added code to allow compilation for esp8266 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I always get a compilation error when trying to compile for esp8266, this is because the WIFi.h file is meant for esp32 and not esp8266 so i just added the library for esp8266 WiFi which is ESP8266WiFI.h. The code will still work for esp32
The WiFi.h library is for esp32 so I simply added some code to allow it to use ESP8266WiFi.h when the board being used is an esp8266 board.
The WiFi.h library is for esp32 so I simply added some code to allow it to use ESP8266WiFi.h when the board being used is an esp8266 board.
|
I noticed the issue when compiling one of the examples on an ESP8266. Inspecting the sourcecode, I noticed that the right wifi- and udp-flavor is now included from the library, but in the examples 'wifi.h' is still included. So that line should ideally be removed from the examples, and for convenience, make a note in the comments that including ezTime.h automatically includes wifi and udp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an error when trying to compile for esp8266 so I simply added
The WiFi.h library is for esp32 so I simply added some code to allow it to use ESP8266WiFi.h when the board being used is an esp8266 board.