Run revdeps

ropensci · May 16, 2023 · 8dda91e · 8dda91e
1 parent de56b51
commit 8dda91e
Show file tree

Hide file tree

Showing 7 changed files with 103 additions and 198 deletions.
diff --git a/R/as_spatial_methods.R b/R/as_spatial_methods.R
@@ -13,7 +13,6 @@ setAs(
   as.SpatialPointsDataFrame.SpatialPoints
 )
 
-
 ## SpatialLines to SpatialLinesDataFrame
 as.SpatialLinesDataFrame.SpatialLines <- function(from) {
   IDs <- sapply(slot(from, "lines"), function(x) slot(x, "ID"))

diff --git a/R/deprecated.R b/R/deprecated.R
@@ -75,7 +75,7 @@ geojson_write.SpatialCollections <- function(input, lat = NULL, lon = NULL,
 }
 
 ## SpatialRings to SpatialPolygonsDataFrame
-as.SpatialPolygonsDataFrame.SpatialRings <- function(from) {
+as_SpatialPolygonsDataFrame.SpatialRings <- function(from) {
 
   lifecycle::deprecate_stop(
     "0.10.0",
@@ -86,12 +86,12 @@ as.SpatialPolygonsDataFrame.SpatialRings <- function(from) {
 
 setAs(
   "SpatialRings", "SpatialPolygonsDataFrame",
-  as.SpatialPolygonsDataFrame.SpatialRings
+  as_SpatialPolygonsDataFrame.SpatialRings
 )
 
 
 ## SpatialRingsDataFrame to SpatialPolygonsDataFrame
-as.SpatialPolygonsDataFrame.SpatialRingsDataFrame <- function(from) {
+as_SpatialPolygonsDataFrame.SpatialRingsDataFrame <- function(from) {
 
   lifecycle::deprecate_stop(
     "0.10.0",
@@ -102,5 +102,5 @@ as.SpatialPolygonsDataFrame.SpatialRingsDataFrame <- function(from) {
 
 setAs(
   "SpatialRingsDataFrame", "SpatialPolygonsDataFrame",
-  as.SpatialPolygonsDataFrame.SpatialRingsDataFrame
+  as_SpatialPolygonsDataFrame.SpatialRingsDataFrame
 )
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,27 +1,17 @@
-This version of geojsonio moves off rgeos and maptools as part of the R-spatial
-retirement project. Additionally, functions for writing topojson were restored.
-
-## Resubmission
-
-This is a resubmission. The previous submission broke rmapzen, as functions
-in maptools behaved differently depending on if rgeos was installed. As this
-release removed the dependency on rgeos for geojsonio and rmapzen only depended
-upon maptools, not rgeos, rmapzen tests produced new errors with this version
-of geojsonio. The author of rmapzen has fixed their package, and I believe this
-version impacts no reverse dependencies.
+This version of geojsonio removes the geojsonlint package from Suggests,
+as that package is expected to be archived in the near future.
 
 ## R CMD check results
 
 0 errors | 0 warnings | 0 notes
 
 ## revdepcheck results
 
-We checked 16 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+We checked 15 reverse dependencies (14 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
 
  * We saw 0 new problems
  * We failed to check 0 packages
 
-
 -------
 
 Thanks,

diff --git a/revdep/README.md b/revdep/README.md
@@ -2,83 +2,79 @@
 
 |field    |value                                                                         |
 |:--------|:-----------------------------------------------------------------------------|
-|version  |R version 4.2.2 Patched (2022-11-10 r83330)                                   |
+|version  |R version 4.3.0 (2023-04-21)                                                  |
 |os       |Ubuntu 22.04.2 LTS                                                            |
 |system   |x86_64, linux-gnu                                                             |
 |ui       |RStudio                                                                       |
 |language |(EN)                                                                          |
 |collate  |en_US.UTF-8                                                                   |
 |ctype    |en_US.UTF-8                                                                   |
 |tz       |America/New_York                                                              |
-|date     |2023-03-07                                                                    |
-|rstudio  |2022.12.0+353 Elsbeth Geranium (desktop)                                      |
+|date     |2023-05-16                                                                    |
+|rstudio  |2023.03.1+446 Cherry Blossom (desktop)                                        |
 |pandoc   |2.19.2 @ /usr/lib/rstudio/resources/app/bin/quarto/bin/tools/ (via rmarkdown) |
 
 # Dependencies
 
-|package     |old      |new      |Δ  |
-|:-----------|:--------|:--------|:--|
-|geojsonio   |0.10.0   |0.11.0   |*  |
-|bit         |4.0.5    |4.0.5    |   |
-|bit64       |4.0.5    |4.0.5    |   |
-|class       |7.3-21   |7.3-21   |   |
-|classInt    |0.4-9    |0.4-9    |   |
-|cli         |3.6.0    |3.6.0    |   |
-|clipr       |0.8.0    |0.8.0    |   |
-|cpp11       |0.4.3    |0.4.3    |   |
-|crayon      |1.5.2    |1.5.2    |   |
-|crul        |1.3      |1.3      |   |
-|curl        |5.0.0    |5.0.0    |   |
-|DBI         |1.1.3    |1.1.3    |   |
-|e1071       |1.7-13   |1.7-13   |   |
-|ellipsis    |0.3.2    |0.3.2    |   |
-|fansi       |1.0.4    |1.0.4    |   |
-|foreign     |0.8-84   |NA       |*  |
-|geojson     |0.3.4    |0.3.4    |   |
-|geojsonsf   |2.0.3    |2.0.3    |   |
-|geometries  |0.2.2    |0.2.2    |   |
-|glue        |1.6.2    |1.6.2    |   |
-|hms         |1.1.2    |1.1.2    |   |
-|httpcode    |0.3.0    |0.3.0    |   |
-|jqr         |1.2.3    |1.2.3    |   |
-|jsonify     |1.2.2    |1.2.2    |   |
-|jsonlite    |1.8.4    |1.8.4    |   |
-|KernSmooth  |2.23-20  |2.23-20  |   |
-|lattice     |0.20-45  |0.20-45  |   |
-|lazyeval    |0.2.2    |0.2.2    |   |
-|lifecycle   |1.0.3    |1.0.3    |   |
-|magrittr    |2.0.3    |2.0.3    |   |
-|maptools    |1.1-6    |NA       |*  |
-|MASS        |7.3-58.3 |7.3-58.3 |   |
-|mime        |0.12     |0.12     |   |
-|pillar      |1.8.1    |1.8.1    |   |
-|pkgconfig   |2.0.3    |2.0.3    |   |
-|prettyunits |1.1.1    |1.1.1    |   |
-|progress    |1.2.2    |1.2.2    |   |
-|protolite   |2.2.0    |2.2.0    |   |
-|proxy       |0.4-27   |0.4-27   |   |
-|R6          |2.5.1    |2.5.1    |   |
-|rapidjsonr  |1.2.0    |1.2.0    |   |
-|Rcpp        |1.0.10   |1.0.10   |   |
-|readr       |2.1.4    |2.1.4    |   |
-|rgeos       |0.6-2    |NA       |*  |
-|rlang       |1.0.6    |1.0.6    |   |
-|s2          |1.1.2    |1.1.2    |   |
-|sf          |1.0-9    |1.0-9    |   |
-|sfheaders   |0.4.2    |0.4.2    |   |
-|sp          |1.6-0    |1.6-0    |   |
-|tibble      |3.1.8    |3.1.8    |   |
-|tidyselect  |1.2.0    |1.2.0    |   |
-|triebeard   |0.4.1    |0.4.1    |   |
-|tzdb        |0.3.0    |0.3.0    |   |
-|units       |0.8-1    |0.8-1    |   |
-|urltools    |1.7.3    |1.7.3    |   |
-|utf8        |1.2.3    |1.2.3    |   |
-|V8          |4.2.2    |4.2.2    |   |
-|vctrs       |0.5.2    |0.5.2    |   |
-|vroom       |1.6.1    |1.6.1    |   |
-|withr       |2.5.0    |2.5.0    |   |
-|wk          |0.7.1    |0.7.1    |   |
+|package     |old     |new         |Δ  |
+|:-----------|:-------|:-----------|:--|
+|geojsonio   |0.11.0  |0.11.0.9000 |*  |
+|bit         |4.0.5   |4.0.5       |   |
+|bit64       |4.0.5   |4.0.5       |   |
+|class       |7.3-22  |7.3-22      |   |
+|classInt    |0.4-9   |0.4-9       |   |
+|cli         |3.6.1   |3.6.1       |   |
+|clipr       |0.8.0   |0.8.0       |   |
+|cpp11       |0.4.3   |0.4.3       |   |
+|crayon      |1.5.2   |1.5.2       |   |
+|crul        |1.3     |1.3         |   |
+|curl        |5.0.0   |5.0.0       |   |
+|DBI         |1.1.3   |1.1.3       |   |
+|e1071       |1.7-13  |1.7-13      |   |
+|fansi       |1.0.4   |1.0.4       |   |
+|geojson     |0.3.4   |0.3.4       |   |
+|geojsonsf   |2.0.3   |2.0.3       |   |
+|geometries  |0.2.2   |0.2.2       |   |
+|glue        |1.6.2   |1.6.2       |   |
+|hms         |1.1.3   |1.1.3       |   |
+|httpcode    |0.3.0   |0.3.0       |   |
+|jqr         |1.2.3   |1.2.3       |   |
+|jsonify     |1.2.2   |1.2.2       |   |
+|jsonlite    |1.8.4   |1.8.4       |   |
+|KernSmooth  |2.23-21 |2.23-21     |   |
+|lattice     |0.21-8  |0.21-8      |   |
+|lazyeval    |0.2.2   |0.2.2       |   |
+|lifecycle   |1.0.3   |1.0.3       |   |
+|magrittr    |2.0.3   |2.0.3       |   |
+|MASS        |7.3-60  |7.3-60      |   |
+|mime        |0.12    |0.12        |   |
+|pillar      |1.9.0   |1.9.0       |   |
+|pkgconfig   |2.0.3   |2.0.3       |   |
+|prettyunits |1.1.1   |1.1.1       |   |
+|progress    |1.2.2   |1.2.2       |   |
+|protolite   |2.2.0   |2.2.0       |   |
+|proxy       |0.4-27  |0.4-27      |   |
+|R6          |2.5.1   |2.5.1       |   |
+|rapidjsonr  |1.2.0   |1.2.0       |   |
+|Rcpp        |1.0.10  |1.0.10      |   |
+|readr       |2.1.4   |2.1.4       |   |
+|rlang       |1.1.1   |1.1.1       |   |
+|s2          |1.1.3   |1.1.3       |   |
+|sf          |1.0-12  |1.0-12      |   |
+|sfheaders   |0.4.2   |0.4.2       |   |
+|sp          |1.6-0   |1.6-0       |   |
+|tibble      |3.2.1   |3.2.1       |   |
+|tidyselect  |1.2.0   |1.2.0       |   |
+|triebeard   |0.4.1   |0.4.1       |   |
+|tzdb        |0.4.0   |0.4.0       |   |
+|units       |0.8-2   |0.8-2       |   |
+|urltools    |1.7.3   |1.7.3       |   |
+|utf8        |1.2.3   |1.2.3       |   |
+|V8          |4.3.0   |4.3.0       |   |
+|vctrs       |0.6.2   |0.6.2       |   |
+|vroom       |1.6.3   |1.6.3       |   |
+|withr       |2.5.0   |2.5.0       |   |
+|wk          |0.7.3   |0.7.3       |   |
 
 # Revdeps
 
@@ -88,11 +84,3 @@
 |:----------|:-------|:-----|:-------|:----|
 |antaresViz |?       |      |        |     |
 
-## New problems (3)
-
-|package  |version |error |warning |note   |
-|:--------|:-------|:-----|:-------|:------|
-|[bRacatus](problems.md#bracatus)|1.0.11  |-1    |        |__+1__ |
-|[mapping](problems.md#mapping)|1.3     |-1    |        |__+1__ |
-|[webglobe](problems.md#webglobe)|1.0.3   |-1    |        |__+1__ |
-
diff --git a/revdep/cran.md b/revdep/cran.md
@@ -1,21 +1,7 @@
 ## revdepcheck results
 
-We checked 16 reverse dependencies (15 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
+We checked 15 reverse dependencies (14 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
 
- * We saw 3 new problems
+ * We saw 0 new problems
  * We failed to check 0 packages
 
-Issues with CRAN packages are summarised below.
-
-### New problems
-(This reports the first line of each new failure)
-
-* bRacatus
-  checking data for non-ASCII characters ... NOTE
-
-* mapping
-  checking data for non-ASCII characters ... NOTE
-
-* webglobe
-  checking installed package size ... NOTE
-
diff --git a/revdep/failures.md b/revdep/failures.md
@@ -1,2 +1,33 @@
 # antaresViz
 
+<details>
+
+* Version: 
+* GitHub: https://github.com/ropensci/geojsonio
+* Source code: NA
+* Number of recursive dependencies: 0
+
+</details>
+
+## Error before installation
+
+### Devel
+
+```
+
+
+
+
+
+
+```
+### CRAN
+
+```
+
+
+
+
+
+
+```
diff --git a/revdep/problems.md b/revdep/problems.md
@@ -1,90 +1 @@
-# bRacatus
-
-<details>
-
-* Version: 1.0.11
-* GitHub: https://github.com/EduardoArle/bRacatus
-* Source code: https://github.com/cran/bRacatus
-* Date/Publication: 2022-12-21 10:10:02 UTC
-* Number of recursive dependencies: 117
-
-Run `revdepcheck::revdep_details(, "bRacatus")` for more info
-
-</details>
-
-## Newly broken
-
-*   checking data for non-ASCII characters ... NOTE
-    ```
-      Note: found 2487 marked UTF-8 strings
-    ```
-
-## Newly fixed
-
-*   checking whether package ‘bRacatus’ can be installed ... ERROR
-    ```
-    Installation failed.
-    See ‘/home/mikemahoney218/codebase/geojsonio/revdep/checks/bRacatus/old/bRacatus.Rcheck/00install.out’ for details.
-    ```
-
-# mapping
-
-<details>
-
-* Version: 1.3
-* GitHub: https://github.com/serafinialessio/mapping
-* Source code: https://github.com/cran/mapping
-* Date/Publication: 2021-07-22 17:40:02 UTC
-* Number of recursive dependencies: 150
-
-Run `revdepcheck::revdep_details(, "mapping")` for more info
-
-</details>
-
-## Newly broken
-
-*   checking data for non-ASCII characters ... NOTE
-    ```
-      Note: found 29618 marked UTF-8 strings
-    ```
-
-## Newly fixed
-
-*   checking whether package ‘mapping’ can be installed ... ERROR
-    ```
-    Installation failed.
-    See ‘/home/mikemahoney218/codebase/geojsonio/revdep/checks/mapping/old/mapping.Rcheck/00install.out’ for details.
-    ```
-
-# webglobe
-
-<details>
-
-* Version: 1.0.3
-* GitHub: https://github.com/r-barnes/webglobe
-* Source code: https://github.com/cran/webglobe
-* Date/Publication: 2020-09-15 22:20:03 UTC
-* Number of recursive dependencies: 89
-
-Run `revdepcheck::revdep_details(, "webglobe")` for more info
-
-</details>
-
-## Newly broken
-
-*   checking installed package size ... NOTE
-    ```
-      installed size is 10.8Mb
-      sub-directories of 1Mb or more:
-        client   9.6Mb
-        doc      1.0Mb
-    ```
-
-## Newly fixed
-
-*   checking whether package ‘webglobe’ can be installed ... ERROR
-    ```
-    Installation failed.
-    See ‘/home/mikemahoney218/codebase/geojsonio/revdep/checks/webglobe/old/webglobe.Rcheck/00install.out’ for details.
-    ```
-
+*Wow, no problems at all. :)*