New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use base R fns to compare versions, add tests, improve readability #144

Merged

slager merged 1 commit into develop from better_way

May 1, 2024

Contributor

slager commented May 1, 2024 •

edited

Greatly simplify internal function .check_dataversion_string()

validate inputs with recently added function validate_DataVersion()
use base R compareVersion() to compare the versions instead of using the previous, more complex method
change naming of returned value elements, and assigned object, to increase code readability outside the function
additional unit tests


          use base R fns to compare versions, add tests, improve readability

95b3028

slager merged commit 29f7601 into develop

7 checks passed

slager deleted the better_way branch

May 1, 2024 02:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment