Local scoping and local tempdirs for edge case test file #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test file created and sometimes deleted numerous test data packages in temporary directories, and had 300+ lines of test code all scoped inside the same testthat block. As such, it was confusing to follow and maybe prone to some hard-to-notice test inter-dependencies.
This PR splits up those tests into 11 different blocks, each with locally scoped variables and locally scoped auto-deleting temporary directories. This was needed prep for some upcoming refactoring I wanted to do, and will be useful for eventual re-organizing of the test files. There's still room to improve these tests, which didn't have many code comments.
This PR also renames
config.yml
todatapackager.yml
in the documentation (inspired by finding an old instance of that filename lingering in the test code itself).