Fix bugs involving roxygen2::roxygenise() attaching the target package to the search path #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roxygen2::roxygenise()
has the not-so-obvious side-effect of attaching the package that is being roxygenized, and leaving it attached on exit, even if it wasn't attached before.This caused warnings to be thrown during the building of
README.Rmd
. The warnings came fromDataPackageR::package_build()
andDataPackageR::document()
, which useroxygen2::roxygenise()
directly or indirectly viadevtools::document()
, respectively, and frominstall.packages()
warning that the package was already attached.In this PR:
Fixed these bugs safely by ensuring the packages will be unloaded via
on.exit()
regardless of whetherinstall = TRUE
orinstall = FALSE
.Added tests to verify the intended behavior. The tests error out on
develop
and pass when cherry-picked to this PR branch.Edited
README.Rmd
to not install themtcars20
package multiple times, and rebuilt the relevant section ofREADME.md
.