Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update README.md #266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Chore: Update README.md #266

wants to merge 2 commits into from

Conversation

juanchoperezj
Copy link
Contributor

@juanchoperezj juanchoperezj commented May 8, 2024

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Description

Refreshing the Readme file.
To preview the changes go to the repo page at this PR branch here


Jira board reference

  • N/A

Notes:


Tasks:

  • Tested on IOS
  • Tested on Android
  • Tested on a small device
  • Tested on a real device
  • Tested all flows related with this PR changes
  • Tested accessibility
  • Added tests

Preview

@juanchoperezj juanchoperezj self-assigned this May 8, 2024
JUNIOR140889
JUNIOR140889 previously approved these changes May 8, 2024
asdolo
asdolo previously approved these changes May 8, 2024
fernandatoledo
fernandatoledo previously approved these changes May 10, 2024
Copy link
Collaborator

@fernandatoledo fernandatoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes enhance the readability, makes the the README.md file much more user friendly 👏


![GHA CI Test](https://github.com/rootstrap/react-native-base/workflows/CI%20Test/badge.svg)
[![Maintainability](https://api.codeclimate.com/v1/badges/8bb29bcea21bb5dda316/maintainability)](https://codeclimate.com/github/rootstrap/react-native-base/maintainability)
[![Test Coverage](https://api.codeclimate.com/v1/badges/8bb29bcea21bb5dda316/test_coverage)](https://codeclimate.com/github/rootstrap/react-native-base/test_coverage)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we don't configure Sonarqube I feel we should keep the codeclimate badges

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! We are keeping them. You can find them in line 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants