Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/force update #265

Merged
merged 13 commits into from
May 16, 2024
Merged

Feat/force update #265

merged 13 commits into from
May 16, 2024

Conversation

JUNIOR140889
Copy link
Contributor

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Description

Force update to minimum version with firebase connection


Jira board reference


Notes:


Tasks:

  • Tested on IOS
  • Tested on Android
  • Tested on a small device
  • Tested on a real device
  • Tested all flows related with this PR changes
  • Tested accessibility
  • Added tests

Preview

simulator_screenshot_F78E7A9F-3D68-4765-AEA4-7278BA21C888

src/network/services/force-update.ts Outdated Show resolved Hide resolved
src/network/services/force-update.ts Outdated Show resolved Hide resolved
src/network/services/force-update.ts Outdated Show resolved Hide resolved
src/network/services/force-update.ts Outdated Show resolved Hide resolved
src/hooks/force-update.ts Outdated Show resolved Hide resolved
src/hooks/force-update.ts Outdated Show resolved Hide resolved
src/hooks/force-update.ts Outdated Show resolved Hide resolved
const openStore = () => {
Platform.select({
ios: Linking.openURL(''),
android: Linking.openURL(''),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add these values to the env file and use them with the react-native-config library

Suggested change
android: Linking.openURL(''),
ios: Linking.openURL(APP_STORE_URL),
android: Linking.openURL(PLAY_STORE_URL),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@juanchoperezj juanchoperezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A few minor comments and this should be good to go!

src/hooks/useValidateAppVersion.ts Outdated Show resolved Hide resolved
src/hooks/useValidateAppVersion.ts Outdated Show resolved Hide resolved
src/hooks/useValidateAppVersion.ts Outdated Show resolved Hide resolved
src/hooks/useValidateAppVersion.ts Outdated Show resolved Hide resolved
src/hooks/useValidateAppVersion.ts Outdated Show resolved Hide resolved
juanchoperezj
juanchoperezj previously approved these changes May 13, 2024
Copy link
Contributor

@juanchoperezj juanchoperezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯

@JUNIOR140889 JUNIOR140889 merged commit 84e4324 into main May 16, 2024
4 checks passed
@JUNIOR140889 JUNIOR140889 deleted the feat/force-update branch May 16, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants