chore: add local expo-cli for simulator.sh script #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stukz
requested review from
marcos09,
juanchoperezj,
asdolo,
fernandatoledo and
jpirazusta
Stukz
commented
Oct 4, 2023
scripts/simulator.sh
Outdated
| else | ||
| react-native run-ios --scheme $1 --configuration $2 ${@:3} | ||
| react-native run-ios --scheme $1 --mode $2 ${@:3} |
There was a problem hiding this comment.
this it's a new change introduced in react-native run command
There was a problem hiding this comment.
You should also update this flag in all android:{env} scripts from package.json.
jpirazusta
previously approved these changes
Oct 4, 2023
asdolo
previously approved these changes
Oct 4, 2023
juanchoperezj
previously approved these changes
Oct 4, 2023
Stukz
dismissed stale reviews from juanchoperezj, asdolo, and jpirazusta
via
9ec65b3
Stukz
force-pushed
the
chore/improve-dx
branch
from
9ec65b3
to
3f1bdd1
Compare
Stukz
force-pushed
the
chore/improve-dx
branch
from
3f1bdd1
to
88369c4
Compare
asdolo
approved these changes
Oct 4, 2023
jpirazusta
reviewed
Oct 4, 2023
| 3. **Lint the app**: `yarn lint` | ||
| 4. **Test the app**: `yarn test` | ||
|
|
||
| **Note: by default we use Expo CLI for iOS if you want to use react-native CLI you must append the following flag to the command:** |
There was a problem hiding this comment.
Suggested change
| **Note: by default we use Expo CLI for iOS if you want to use react-native CLI you must append the following flag to the command:** | |
| **Note: by default we use Expo CLI for iOS. If you want to use react-native CLI you must append the following flag to the command:** |
jpirazusta
approved these changes
Oct 4, 2023
asdolo
approved these changes
Oct 4, 2023
|
|
||
| 1. Rename your new project using `yarn rename` or `npm run rename` | ||
| 2. Start on android or ios: `yarn android:{env}` or `yarn ios:{env}` (envs: `dev`,`qa`, `staging`, and `prod`) | ||
| 2.1 You can also create `.env.prod`, `.env.staging`, and `.env.qa` to define environment variables for production and staging. |
There was a problem hiding this comment.
Suggested change
| 2.1 You can also create `.env.prod`, `.env.staging`, and `.env.qa` to define environment variables for production and staging. | |
| 2.1 You can also create `.env.prod`, `.env.staging`, and `.env.qa` to define environment variables for production, staging and QA. |
| npx pod-install | ||
| ``` | ||
|
|
||
| ## Commands | ||
|
|
||
| 1. **Start metro bundler**: `yarn start` |
There was a problem hiding this comment.
Should we use an unordered list here?
| @@ -78,7 +79,8 @@ sonar-scanner \ | |||
| -Dsonar.sources=. \ | |||
| -Dsonar.projectBaseDir=. \ | |||
| -Dsonar.javascript.lcov.reportPaths=coverage/lcov.info | |||
| -Dsonar.coverage.exclusions=**/spec.js,**/__mocks__/**,**/**.spec.js,**/**.config.js,**/rnbv.js,**/android/**,**/ios/**,**/**.styles.js,**/tests/**,**/__mocks__/**,**/httpClient/**,**/jest-setup.js,**/constants/**,**/assets/**,**/node_modules/**,**/coverage/** | |||
| -Dsonar.coverage.exclusions=**/spec.js,**/**mocks**/**,**/**.spec.js,**/**.config.js,**/rnbv.js,**/android/**,**/ios/**,**/**.styles.js,**/tests/**,**/**mocks**/**,**/httpClient/**,**/jest-setup.js,**/constants/**,**/assets/**,**/node_modules/**,**/coverage/** | |||
There was a problem hiding this comment.
I believe the change from __mocks__ to mocks might have been unintentional, because this project uses __mocks__ folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description
New Expo CLI it's embedded in the Expo package, in order to use it we have to include it as devDep.
Updated simulator.sh script to support this