Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificates refactor #1310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 0 additions & 42 deletions .github/actions/setup-step-ca/action.yml

This file was deleted.

4 changes: 1 addition & 3 deletions .github/files/wordpress_sites.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
letsencrypt_contact_emails:
acme_ca_contact_emails:
- admin@example.com

wordpress_sites:
Expand All @@ -14,7 +14,6 @@ wordpress_sites:
enabled: false
ssl:
enabled: false
provider: letsencrypt
cache:
enabled: true
example-https.com:
Expand All @@ -29,6 +28,5 @@ wordpress_sites:
enabled: false
ssl:
enabled: true
provider: letsencrypt
cache:
enabled: false
3 changes: 1 addition & 2 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
- uses: actions/setup-python@v2
with:
python-version: '3.9'
- uses: ./.github/actions/setup-step-ca
- uses: roots/setup-trellis-cli@v1
with:
ansible-vault-password: 'fake'
Expand All @@ -50,7 +49,7 @@ jobs:
- run: trellis exec ansible-playbook --version
working-directory: example.com/trellis
- name: Provision
run: trellis provision --extra-vars "web_user=runner letsencrypt_ca=https://127.0.0.1:8443/acme/acme" production
run: trellis provision --extra-vars "web_user=runner acme_ca_force_local_server=true" production
working-directory: example.com
- name: Deploy non-https site
run: trellis deploy --extra-vars "web_user=runner project_git_repo=https://github.com/roots/bedrock.git" production example.com
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ vendor/roles
*.py[co]
*.retry
.trellis/virtualenv
.trellis/root_certificates
1 change: 1 addition & 0 deletions dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- { role: xdebug, tags: [php, xdebug] }
- { role: memcached, tags: [memcached] }
- { role: nginx, tags: [nginx] }
- { role: ssl_certificates, tags: [ssl_certificates, ssl], when: sites_using_ssl | count }
- { role: logrotate, tags: [logrotate] }
- { role: composer, tags: [composer] }
- { role: wp-cli, tags: [wp-cli] }
Expand Down
6 changes: 6 additions & 0 deletions group_vars/all/helpers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@ wordpress_env_defaults:
domain_current_site: "{{ site_hosts_canonical | first }}"
wp_debug_log: "{{ www_root }}/{{ item.key }}/logs/debug.log"

ssl_defaults:
acme:
challenge:
type: http-01

site_env: "{{ wordpress_env_defaults | combine(vault_wordpress_env_defaults | default({}), item.value.env | default({}), vault_wordpress_sites[item.key].env) }}"
site_ssl: "{{ ssl_defaults | combine(item.value.ssl | default({}) ) }}"
site_hosts_canonical: "{{ item.value.site_hosts | map(attribute='canonical') | list }}"
site_hosts_redirects: "{{ item.value.site_hosts | selectattr('redirects', 'defined') | sum(attribute='redirects', start=[]) | list }}"
site_hosts: "{{ site_hosts_canonical | union(site_hosts_redirects) }}"
Expand Down
2 changes: 1 addition & 1 deletion group_vars/development/main.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
acme_tiny_challenges_directory: "{{ www_root }}/letsencrypt"
env: development
acme_ca_server: "https://127.0.0.1:{{ step_ca_port }}/acme/acme/directory"
mysql_root_password: "{{ vault_mysql_root_password }}" # Define this variable in group_vars/development/vault.yml
web_user: vagrant
1 change: 0 additions & 1 deletion group_vars/development/wordpress_sites.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,5 @@ wordpress_sites:
enabled: false
ssl:
enabled: false
provider: self-signed
cache:
enabled: false
1 change: 0 additions & 1 deletion group_vars/production/wordpress_sites.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@ wordpress_sites:
enabled: false
ssl:
enabled: false
provider: letsencrypt
cache:
enabled: false
1 change: 0 additions & 1 deletion group_vars/staging/wordpress_sites.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@ wordpress_sites:
enabled: false
ssl:
enabled: false
provider: letsencrypt
cache:
enabled: false
2 changes: 1 addition & 1 deletion roles/common/tasks/disable_challenge_sites.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: disable temporary challenge sites
file:
path: "{{ nginx_path }}/sites-enabled/letsencrypt-{{ item }}.conf"
path: "{{ nginx_path }}/sites-enabled/acme-challenge-{{ item }}.conf"
state: absent
loop: "{{ wordpress_sites.keys() | list }}"
notify: reload nginx
2 changes: 1 addition & 1 deletion roles/common/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
loop_control:
label: "{{ item.key }}"
when: item.value.site_hosts | rejectattr('canonical', 'defined') | list | count
tags: [letsencrypt, wordpress]
tags: [ssl, wordpress]

- name: Import PHP version specific vars
include_vars: "{{ lookup('first_found', params) }}"
Expand Down
9 changes: 0 additions & 9 deletions roles/letsencrypt/README.md

This file was deleted.

40 changes: 0 additions & 40 deletions roles/letsencrypt/defaults/main.yml

This file was deleted.

82 changes: 0 additions & 82 deletions roles/letsencrypt/library/test_challenges.py

This file was deleted.

60 changes: 0 additions & 60 deletions roles/letsencrypt/tasks/certificates.yml

This file was deleted.

15 changes: 0 additions & 15 deletions roles/letsencrypt/tasks/main.yml

This file was deleted.