Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fix declaration for C99 and re-enable Gnu.C test. #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marsupial
Copy link
Contributor

The test was failing for a reason that likely shouldn't be ignored.

This reverts commit 5947e13.

@bellenot
Copy link
Member

bellenot commented Jul 7, 2017

And it's still failing...

@marsupial
Copy link
Contributor Author

Hopefully no longer.

@bellenot
Copy link
Member

bellenot commented Jul 7, 2017

Remove C++11 test which Visual Studio cannot handle.

And what about the other platforms?

@marsupial
Copy link
Contributor Author

The test is for GNU keywords, having -std=gnu++14 -std=gnu++1z is enough as they test the same mechanism.
-std=gnu++11 really adds nothing but failure for Windows, and fixing for that would mean you're just testing that C++11 cannot run on Windows

If someone feels it is really necessary, then it would probably be best to have a directory devoted to C++11 tests that are not activated on Windows rather than allowing failure all over.

@bellenot
Copy link
Member

bellenot commented Jul 7, 2017

OK, thanks for the explanation @marsupial. If @vgvassilev confirm (and agrees), and if it fixes the test, then it is would be fine with me

@marsupial
Copy link
Contributor Author

Updated again to work-around the Windows issue without dropping it entirely.

@vgvassilev
Copy link
Member

Looks good to me.

@pcanal
Copy link
Member

pcanal commented Aug 16, 2017

@phsft-bot build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants