Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken import of class types. #171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marsupial
Copy link
Contributor

There are two issues, the first seems like cling's fault, the second possibly clangs.

  1. Importing a CxxConstructor decl can fail as cling it is using the string name for lookup.
  2. Importing C++ conversion operators does not work.

Sprinkle with more modern C++: auto to make more readable, emplace to avoid temporaries, and range based for loops.
@ferdymercury
Copy link
Contributor

I think this repo is just a mirror, consider moving your PR here instead: https://github.com/root-project/root/pulls (subdirectory interpreter/cling). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants